Initial Commit
This commit is contained in:
@@ -0,0 +1,71 @@
|
||||
<?php
|
||||
/**
|
||||
* Squiz_Sniffs_Strings_ConcatenationSpacingSniff.
|
||||
*
|
||||
* PHP version 5
|
||||
*
|
||||
* @category PHP
|
||||
* @package PHP_CodeSniffer
|
||||
* @author Greg Sherwood <gsherwood@squiz.net>
|
||||
* @author Marc McIntyre <mmcintyre@squiz.net>
|
||||
* @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
|
||||
* @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
|
||||
* @link http://pear.php.net/package/PHP_CodeSniffer
|
||||
*/
|
||||
|
||||
/**
|
||||
* Squiz_Sniffs_Strings_ConcatenationSpacingSniff.
|
||||
*
|
||||
* Makes sure there are no spaces between the concatenation operator (.) and
|
||||
* the strings being concatenated.
|
||||
*
|
||||
* @category PHP
|
||||
* @package PHP_CodeSniffer
|
||||
* @author Greg Sherwood <gsherwood@squiz.net>
|
||||
* @author Marc McIntyre <mmcintyre@squiz.net>
|
||||
* @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
|
||||
* @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
|
||||
* @version Release: 1.3.3
|
||||
* @link http://pear.php.net/package/PHP_CodeSniffer
|
||||
*/
|
||||
class Squiz_Sniffs_Strings_ConcatenationSpacingSniff implements PHP_CodeSniffer_Sniff
|
||||
{
|
||||
|
||||
|
||||
/**
|
||||
* Returns an array of tokens this test wants to listen for.
|
||||
*
|
||||
* @return array
|
||||
*/
|
||||
public function register()
|
||||
{
|
||||
return array(T_STRING_CONCAT);
|
||||
|
||||
}//end register()
|
||||
|
||||
|
||||
/**
|
||||
* Processes this test, when one of its tokens is encountered.
|
||||
*
|
||||
* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
|
||||
* @param int $stackPtr The position of the current token in the
|
||||
* stack passed in $tokens.
|
||||
*
|
||||
* @return void
|
||||
*/
|
||||
public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
|
||||
{
|
||||
$tokens = $phpcsFile->getTokens();
|
||||
if ($tokens[($stackPtr - 1)]['code'] === T_WHITESPACE
|
||||
|| $tokens[($stackPtr + 1)]['code'] === T_WHITESPACE
|
||||
) {
|
||||
$message = 'Concat operator must not be surrounded by spaces';
|
||||
$phpcsFile->addError($message, $stackPtr, 'Missing');
|
||||
}
|
||||
|
||||
}//end process()
|
||||
|
||||
|
||||
}//end class
|
||||
|
||||
?>
|
||||
@@ -0,0 +1,135 @@
|
||||
<?php
|
||||
/**
|
||||
* Squiz_Sniffs_Strings_DoubleQuoteUsageSniff.
|
||||
*
|
||||
* PHP version 5
|
||||
*
|
||||
* @category PHP
|
||||
* @package PHP_CodeSniffer
|
||||
* @author Greg Sherwood <gsherwood@squiz.net>
|
||||
* @author Marc McIntyre <mmcintyre@squiz.net>
|
||||
* @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
|
||||
* @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
|
||||
* @link http://pear.php.net/package/PHP_CodeSniffer
|
||||
*/
|
||||
|
||||
/**
|
||||
* Squiz_Sniffs_Strings_DoubleQuoteUsageSniff.
|
||||
*
|
||||
* Makes sure that any use of Double Quotes ("") are warranted.
|
||||
*
|
||||
* @category PHP
|
||||
* @package PHP_CodeSniffer
|
||||
* @author Greg Sherwood <gsherwood@squiz.net>
|
||||
* @author Marc McIntyre <mmcintyre@squiz.net>
|
||||
* @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
|
||||
* @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
|
||||
* @version Release: 1.3.3
|
||||
* @link http://pear.php.net/package/PHP_CodeSniffer
|
||||
*/
|
||||
class Squiz_Sniffs_Strings_DoubleQuoteUsageSniff implements PHP_CodeSniffer_Sniff
|
||||
{
|
||||
|
||||
|
||||
/**
|
||||
* Returns an array of tokens this test wants to listen for.
|
||||
*
|
||||
* @return array
|
||||
*/
|
||||
public function register()
|
||||
{
|
||||
return array(
|
||||
T_CONSTANT_ENCAPSED_STRING,
|
||||
T_DOUBLE_QUOTED_STRING,
|
||||
);
|
||||
|
||||
}//end register()
|
||||
|
||||
|
||||
/**
|
||||
* Processes this test, when one of its tokens is encountered.
|
||||
*
|
||||
* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
|
||||
* @param int $stackPtr The position of the current token
|
||||
* in the stack passed in $tokens.
|
||||
*
|
||||
* @return void
|
||||
*/
|
||||
public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
|
||||
{
|
||||
$tokens = $phpcsFile->getTokens();
|
||||
|
||||
// We are only interested in the first token in a multi-line string.
|
||||
if ($tokens[$stackPtr]['code'] === $tokens[($stackPtr - 1)]['code']) {
|
||||
return;
|
||||
}
|
||||
|
||||
$workingString = $tokens[$stackPtr]['content'];
|
||||
$i = ($stackPtr + 1);
|
||||
while ($tokens[$i]['code'] === $tokens[$stackPtr]['code']) {
|
||||
$workingString .= $tokens[$i]['content'];
|
||||
$i++;
|
||||
}
|
||||
|
||||
// Check if it's a double quoted string.
|
||||
if (strpos($workingString, '"') === false) {
|
||||
return;
|
||||
}
|
||||
|
||||
// Make sure it's not a part of a string started in a previous line.
|
||||
// If it is, then we have already checked it.
|
||||
if ($workingString[0] !== '"') {
|
||||
return;
|
||||
}
|
||||
|
||||
// The use of variables in double quoted strings is not allowed.
|
||||
if ($tokens[$stackPtr]['code'] === T_DOUBLE_QUOTED_STRING) {
|
||||
$stringTokens = token_get_all('<?php '.$workingString);
|
||||
foreach ($stringTokens as $token) {
|
||||
if (is_array($token) === true && $token[0] === T_VARIABLE) {
|
||||
$error = 'Variable "%s" not allowed in double quoted string; use concatenation instead';
|
||||
$data = array($token[1]);
|
||||
$phpcsFile->addError($error, $stackPtr, 'ContainsVar', $data);
|
||||
}
|
||||
}
|
||||
|
||||
return;
|
||||
}//end if
|
||||
|
||||
// Work through the following tokens, in case this string is stretched
|
||||
// over multiple Lines.
|
||||
for ($i = ($stackPtr + 1); $i < $phpcsFile->numTokens; $i++) {
|
||||
if ($tokens[$i]['type'] !== 'T_CONSTANT_ENCAPSED_STRING') {
|
||||
break;
|
||||
}
|
||||
|
||||
$workingString .= $tokens[$i]['content'];
|
||||
}
|
||||
|
||||
$allowedChars = array(
|
||||
'\0',
|
||||
'\n',
|
||||
'\r',
|
||||
'\f',
|
||||
'\t',
|
||||
'\v',
|
||||
'\x',
|
||||
'\'',
|
||||
);
|
||||
|
||||
foreach ($allowedChars as $testChar) {
|
||||
if (strpos($workingString, $testChar) !== false) {
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
$error = 'String %s does not require double quotes; use single quotes instead';
|
||||
$data = array($workingString);
|
||||
$phpcsFile->addError($error, $stackPtr, 'NotRequired', $data);
|
||||
|
||||
}//end process()
|
||||
|
||||
|
||||
}//end class
|
||||
|
||||
?>
|
||||
@@ -0,0 +1,84 @@
|
||||
<?php
|
||||
/**
|
||||
* Squiz_Sniffs_Strings_EchoedStringsSniff.
|
||||
*
|
||||
* PHP version 5
|
||||
*
|
||||
* @category PHP
|
||||
* @package PHP_CodeSniffer
|
||||
* @author Greg Sherwood <gsherwood@squiz.net>
|
||||
* @author Marc McIntyre <mmcintyre@squiz.net>
|
||||
* @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
|
||||
* @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
|
||||
* @link http://pear.php.net/package/PHP_CodeSniffer
|
||||
*/
|
||||
|
||||
/**
|
||||
* Squiz_Sniffs_Strings_EchoedStringsSniff.
|
||||
*
|
||||
* Makes sure that any strings that are "echoed" are not enclosed in brackets
|
||||
* like a function call.
|
||||
*
|
||||
* @category PHP
|
||||
* @package PHP_CodeSniffer
|
||||
* @author Greg Sherwood <gsherwood@squiz.net>
|
||||
* @author Marc McIntyre <mmcintyre@squiz.net>
|
||||
* @copyright 2006-2011 Squiz Pty Ltd (ABN 77 084 670 600)
|
||||
* @license http://matrix.squiz.net/developer/tools/php_cs/licence BSD Licence
|
||||
* @version Release: 1.3.3
|
||||
* @link http://pear.php.net/package/PHP_CodeSniffer
|
||||
*/
|
||||
class Squiz_Sniffs_Strings_EchoedStringsSniff implements PHP_CodeSniffer_Sniff
|
||||
{
|
||||
|
||||
|
||||
/**
|
||||
* Returns an array of tokens this test wants to listen for.
|
||||
*
|
||||
* @return array
|
||||
*/
|
||||
public function register()
|
||||
{
|
||||
return array(T_ECHO);
|
||||
|
||||
}//end register()
|
||||
|
||||
|
||||
/**
|
||||
* Processes this test, when one of its tokens is encountered.
|
||||
*
|
||||
* @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
|
||||
* @param int $stackPtr The position of the current token in the
|
||||
* stack passed in $tokens.
|
||||
*
|
||||
* @return void
|
||||
*/
|
||||
public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
|
||||
{
|
||||
$tokens = $phpcsFile->getTokens();
|
||||
|
||||
$firstContent = $phpcsFile->findNext(array(T_WHITESPACE), ($stackPtr + 1), null, true);
|
||||
// If the first non-whitespace token is not an opening parenthesis, then we are not concerned.
|
||||
if ($tokens[$firstContent]['code'] !== T_OPEN_PARENTHESIS) {
|
||||
return;
|
||||
}
|
||||
|
||||
$endOfStatement = $phpcsFile->findNext(array(T_SEMICOLON), $stackPtr, null, false);
|
||||
|
||||
// If the token before the semi-colon is not a closing parenthesis, then we are not concerned.
|
||||
if ($tokens[($endOfStatement - 1)]['code'] !== T_CLOSE_PARENTHESIS) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (($phpcsFile->findNext(PHP_CodeSniffer_Tokens::$operators, $stackPtr, $endOfStatement, false)) === false) {
|
||||
// There are no arithmetic operators in this.
|
||||
$error = 'Echoed strings should not be bracketed';
|
||||
$phpcsFile->addError($error, $stackPtr, 'HasBracket');
|
||||
}
|
||||
|
||||
}//end process()
|
||||
|
||||
|
||||
}//end class
|
||||
|
||||
?>
|
||||
Reference in New Issue
Block a user