1 Commits

4 changed files with 13 additions and 29 deletions

View File

@@ -19,7 +19,6 @@ public class BadCasesTest {
public void assertNewTasksAreNotNull() { public void assertNewTasksAreNotNull() {
int workerId = manager.createWorker("Alfred"); int workerId = manager.createWorker("Alfred");
assertThrows(IllegalArgumentException.class, () -> manager.addTask(workerId, null, null)); assertThrows(IllegalArgumentException.class, () -> manager.addTask(workerId, null, null));
manager.removeWorker(workerId);
} }
@Test @Test
@DisplayName("Assert List isn't empty after adding a task") @DisplayName("Assert List isn't empty after adding a task")
@@ -27,8 +26,6 @@ public class BadCasesTest {
int workerId = manager.createWorker("Alfred"); int workerId = manager.createWorker("Alfred");
int taskId = manager.addTask(workerId, "Run", "Jog 10 Miles"); int taskId = manager.addTask(workerId, "Run", "Jog 10 Miles");
assertFalse(manager.getTaskMap().isEmpty()); assertFalse(manager.getTaskMap().isEmpty());
manager.removeWorker(workerId);
manager.removeTask(taskId);
} }
@Test @Test
@DisplayName("Assert only existing tasks can be edited") @DisplayName("Assert only existing tasks can be edited")
@@ -36,7 +33,6 @@ public class BadCasesTest {
int workerId = manager.createWorker("Alfred"); int workerId = manager.createWorker("Alfred");
assertThrows(IllegalArgumentException.class, () -> manager.editTask(workerId, 99969, "I", "am Illegal")); assertThrows(IllegalArgumentException.class, () -> manager.editTask(workerId, 99969, "I", "am Illegal"));
assertThrows(IllegalArgumentException.class, () -> manager.editTask(22200, 99969, "I", "am Illegal")); assertThrows(IllegalArgumentException.class, () -> manager.editTask(22200, 99969, "I", "am Illegal"));
manager.removeWorker(workerId);
} }
@Test @Test
@DisplayName("Assert Add Task is programmed defensively") @DisplayName("Assert Add Task is programmed defensively")
@@ -44,7 +40,6 @@ public class BadCasesTest {
int workerId = manager.createWorker("Alfred"); int workerId = manager.createWorker("Alfred");
assertThrows(IllegalArgumentException.class, () -> manager.addTask( 20203,"I", "am Illegal")); assertThrows(IllegalArgumentException.class, () -> manager.addTask( 20203,"I", "am Illegal"));
assertThrows(IllegalArgumentException.class, () -> manager.addTask( workerId,null, null)); assertThrows(IllegalArgumentException.class, () -> manager.addTask( workerId,null, null));
manager.removeWorker(workerId);
} }
@Test @Test
@DisplayName("Assert that Remove Task is programmed defensively") @DisplayName("Assert that Remove Task is programmed defensively")
@@ -72,7 +67,5 @@ public class BadCasesTest {
} catch (Exception e) { } catch (Exception e) {
fail("Should not crash just because a command is invalid"); fail("Should not crash just because a command is invalid");
} }
manager.removeWorker(workerId);
manager.removeTask(taskId);
} }
} }

View File

@@ -15,7 +15,7 @@ public class DatabaseBadCasesTest {
public void setup() throws SQLException { public void setup() throws SQLException {
databaseManager = new SimpleDatabaseManager(); databaseManager = new SimpleDatabaseManager();
databaseManager.connect(); databaseManager.connect();
databaseManager.clearDatabase(); //databaseManager.clearDatabase();
} }
@Test @Test
@@ -27,6 +27,9 @@ public class DatabaseBadCasesTest {
databaseManager.saveTask(task); databaseManager.saveTask(task);
databaseManager.saveTask(taskFaker); databaseManager.saveTask(taskFaker);
databaseManager.deleteTask(task.getTaskId());
databaseManager.deleteTask(taskFaker.getTaskId());
} }
@Test @Test
@@ -38,5 +41,8 @@ public class DatabaseBadCasesTest {
databaseManager.saveWorker(worker); databaseManager.saveWorker(worker);
databaseManager.saveWorker(workerFaker); databaseManager.saveWorker(workerFaker);
databaseManager.deleteWorker(worker.getId());
databaseManager.deleteWorker(workerFaker.getId());
} }
} }

View File

@@ -19,7 +19,7 @@ public class DatabaseGoodCasesTest {
public void setup() throws SQLException { public void setup() throws SQLException {
databaseManager = new SimpleDatabaseManager(); databaseManager = new SimpleDatabaseManager();
databaseManager.connect(); databaseManager.connect();
databaseManager.clearDatabase(); //databaseManager.clearDatabase();
} }
@Test @Test
@@ -37,7 +37,7 @@ public class DatabaseGoodCasesTest {
assertEquals(task.getName(), reTask.getName()); assertEquals(task.getName(), reTask.getName());
assertEquals(task.getWorkerId(), reTask.getWorkerId()); assertEquals(task.getWorkerId(), reTask.getWorkerId());
assertEquals(1, databaseManager.getTotalNumberOfTasks()); databaseManager.deleteTask(task.getTaskId());
} }
@Test @Test
@@ -53,9 +53,11 @@ public class DatabaseGoodCasesTest {
assertEquals(worker.getId(), reWorker.getId()); assertEquals(worker.getId(), reWorker.getId());
assertEquals(worker.getName(), reWorker.getName()); assertEquals(worker.getName(), reWorker.getName());
databaseManager.deleteWorker(worker.getId());
} }
@Test /*@Test
@DisplayName("Clearing the database (Task and Worker) test") @DisplayName("Clearing the database (Task and Worker) test")
public void clearDatabaseTest() throws SQLException, InterruptedException { public void clearDatabaseTest() throws SQLException, InterruptedException {
Task task1 = new Task(10, 5, "Hello", "World"); Task task1 = new Task(10, 5, "Hello", "World");
@@ -79,5 +81,5 @@ public class DatabaseGoodCasesTest {
assertEquals(0, databaseManager.getTotalNumberOfTasks()); assertEquals(0, databaseManager.getTotalNumberOfTasks());
assertEquals(0, databaseManager.getTotalNumberOfWorkers()); assertEquals(0, databaseManager.getTotalNumberOfWorkers());
} }*/
} }

View File

@@ -23,8 +23,6 @@ public class GoodCasesTest {
int taskId = manager.addTask(workerId, "Run", "Jog 10 Miles"); int taskId = manager.addTask(workerId, "Run", "Jog 10 Miles");
assertNotNull(manager.getTask(taskId)); assertNotNull(manager.getTask(taskId));
assertEquals("Run", manager.getTask(taskId).getName()); assertEquals("Run", manager.getTask(taskId).getName());
manager.removeWorker(workerId);
manager.removeTask(taskId);
} }
@Test @Test
@@ -34,8 +32,6 @@ public class GoodCasesTest {
int workerId = manager.createWorker("Alfred"); int workerId = manager.createWorker("Alfred");
int taskId = manager.addTask(workerId, "Run", "Jog 10 Miles"); int taskId = manager.addTask(workerId, "Run", "Jog 10 Miles");
assertEquals(sizeCount + 1, manager.getTaskMap().size()); assertEquals(sizeCount + 1, manager.getTaskMap().size());
manager.removeWorker(workerId);
manager.removeTask(taskId);
} }
@Test @Test
@@ -46,8 +42,6 @@ public class GoodCasesTest {
manager.editTask(workerId, taskId, "Walk", "Walk 3 Miles"); manager.editTask(workerId, taskId, "Walk", "Walk 3 Miles");
assertEquals("Walk", manager.getTask(taskId).getName()); assertEquals("Walk", manager.getTask(taskId).getName());
assertEquals("Walk 3 Miles", manager.getTask(taskId).getDescription()); assertEquals("Walk 3 Miles", manager.getTask(taskId).getDescription());
manager.removeWorker(workerId);
manager.removeTask(taskId);
} }
@Test @Test
@@ -59,7 +53,6 @@ public class GoodCasesTest {
assertEquals(sizeCount + 1, manager.getTaskMap().size()); assertEquals(sizeCount + 1, manager.getTaskMap().size());
manager.removeTask(taskId); manager.removeTask(taskId);
assertEquals(sizeCount, manager.getTaskMap().size()); assertEquals(sizeCount, manager.getTaskMap().size());
manager.removeWorker(workerId);
} }
@Test @Test
@@ -69,7 +62,6 @@ public class GoodCasesTest {
int taskId = manager.addTask(workerId, "Run", "Jog 10 Miles"); int taskId = manager.addTask(workerId, "Run", "Jog 10 Miles");
manager.removeTask(taskId); manager.removeTask(taskId);
assertThrows(IllegalArgumentException.class, () -> manager.getTask(taskId)); assertThrows(IllegalArgumentException.class, () -> manager.getTask(taskId));
manager.removeWorker(workerId);
} }
@Test @Test
@@ -82,8 +74,6 @@ public class GoodCasesTest {
assertEquals(manager.getWorkerMap().get(workerId).getId(), workerId); assertEquals(manager.getWorkerMap().get(workerId).getId(), workerId);
assertEquals(manager.getTask(taskId).getTaskId(), taskId); assertEquals(manager.getTask(taskId).getTaskId(), taskId);
assertEquals(manager.getTask(taskId).getWorkerId(), workerId); assertEquals(manager.getTask(taskId).getWorkerId(), workerId);
manager.removeWorker(workerId);
manager.removeTask(taskId);
} }
@@ -96,8 +86,6 @@ public class GoodCasesTest {
assertSame(TaskState.FINISHED, manager.getTask(taskId).getTaskState()); assertSame(TaskState.FINISHED, manager.getTask(taskId).getTaskState());
manager.unfinishTask(workerId, taskId); manager.unfinishTask(workerId, taskId);
assertSame(TaskState.IN_PROGRESS, manager.getTask(taskId).getTaskState()); assertSame(TaskState.IN_PROGRESS, manager.getTask(taskId).getTaskState());
manager.removeWorker(workerId);
manager.removeTask(taskId);
} }
@Test @Test
@@ -132,7 +120,6 @@ public class GoodCasesTest {
assertDoesNotThrow(() -> manager.getUserCommands().handleInput("remove")); assertDoesNotThrow(() -> manager.getUserCommands().handleInput("remove"));
assertDoesNotThrow(() -> manager.getUserCommands().handleInput("back")); assertDoesNotThrow(() -> manager.getUserCommands().handleInput("back"));
assertDoesNotThrow(() -> manager.getUserCommands().handleInput("edit")); assertDoesNotThrow(() -> manager.getUserCommands().handleInput("edit"));
manager.removeWorker(workerId);
} }
@Test @Test
@DisplayName("Check that editing is possible through UI") @DisplayName("Check that editing is possible through UI")
@@ -146,8 +133,6 @@ public class GoodCasesTest {
assertEquals("Walk", manager.getTask(taskId).getName()); assertEquals("Walk", manager.getTask(taskId).getName());
assertEquals("Walk 3 Miles", manager.getTask(taskId).getDescription()); assertEquals("Walk 3 Miles", manager.getTask(taskId).getDescription());
manager.getUserCommands().handleInput("back"); manager.getUserCommands().handleInput("back");
manager.removeWorker(workerId);
manager.removeTask(taskId);
} }
@Test @Test
@DisplayName("Assert that removing Workers is possible through the UI") @DisplayName("Assert that removing Workers is possible through the UI")
@@ -159,8 +144,6 @@ public class GoodCasesTest {
assertDoesNotThrow(() -> manager.getUserCommands().handleInput("remove")); assertDoesNotThrow(() -> manager.getUserCommands().handleInput("remove"));
manager.getUserCommands().handleInput(workerId2 + ""); manager.getUserCommands().handleInput(workerId2 + "");
assertDoesNotThrow(() -> manager.getUserCommands().handleInput("back")); assertDoesNotThrow(() -> manager.getUserCommands().handleInput("back"));
manager.removeWorker(workerId);
manager.removeWorker(workerId2);
} }
@Test @Test
@DisplayName("Assert that removing a worker removes the worker from the worker list") @DisplayName("Assert that removing a worker removes the worker from the worker list")